Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX-78] rpk: fix incorrect parsing of ipv6 addresses #24982

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[UX-78] rpk: fix incorrect parsing of ipv6 addresses #24982

wants to merge 1 commit into from

Conversation

r-vasquez
Copy link
Contributor

This fixes a bug where we were adding double
brackets to IPV6 addresses.

Fixes #23363

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

Bug Fixes

  • rpk: fixes a bug where rpk incorrectly handles IPv6 by adding extra brackets.

@r-vasquez
rpk: fix incorrect parsing of ipv6 addresses
3607a3b 
This fixes a bug where we were adding double
brackets to IPV6 addresses.

Fixes redpanda-data#23363
@r-vasquez r-vasquez requested review from kbatuigas and a team as code owners January 29, 2025 23:13
@r-vasquez r-vasquez requested review from sago2k8 and removed request for a team January 29, 2025 23:13
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61377
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61377#0194b4a3-744f-4eb0-80d8-3c450f568324 FLAKY 1/3
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/61377#0194b4a3-744d-4862-8a99-7948c128396b FLAKY 1/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbatuigas kbatuigas Awaiting requested review from kbatuigas kbatuigas is a code owner

@sago2k8 sago2k8 Awaiting requested review from sago2k8 sago2k8 is a code owner automatically assigned from redpanda-data/ux-rpk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/rpk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpk fails to connect to an ipv6 admin-api address
2 participants
@r-vasquez @vbotbuildovich