Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.3.x] pandaproxy/sr: protobuf rendering: refactor string rendering #24994

Merged
merged 1 commit into from
Feb 2, 2025
Merged

[v24.3.x] pandaproxy/sr: protobuf rendering: refactor string rendering #24994

merged 1 commit into from
Feb 2, 2025

Conversation

IoannisRP
Copy link
Contributor

Backport #24992

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@IoannisRP
pandaproxy/sr: protobuf rendering: refactor string rendering
27d08e9 
Moved away from fmt debug format for 2 reasons:
1. Debug format is not supported in earlier versions of fmt
that we still use.
2. Make the intent more explicit.

(cherry picked from commit efdbf23)
@IoannisRP IoannisRP requested a review from BenPope January 31, 2025 19:23
@vbotbuildovich
Copy link
Collaborator

CI test results

test results on build#61454
test_id test_kind job_url test_status passed
rptest.tests.archive_retention_test.CloudArchiveRetentionTest.test_delete.cloud_storage_type=CloudStorageType.ABS.retention_type=retention.ms ducktape https://buildkite.com/redpanda/redpanda/builds/61454#0194be32-e81a-4ac1-b6e2-3e1e6ec7e786 FLAKY 1/2

@IoannisRP IoannisRP requested review from michael-redpanda and BenPope and removed request for BenPope February 1, 2025 12:40
@IoannisRP IoannisRP enabled auto-merge February 1, 2025 12:40
@IoannisRP IoannisRP mentioned this pull request Feb 1, 2025
Closed
@IoannisRP IoannisRP merged commit 83618d9 into redpanda-data:v24.3.x Feb 2, 2025
17 checks passed
@BenPope BenPope added this to the v24.3.5 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenPope BenPope BenPope approved these changes

@michael-redpanda michael-redpanda Awaiting requested review from michael-redpanda

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
v24.3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@IoannisRP @vbotbuildovich @BenPope