Implement ALL for strings (#333)

redplanetlabs · Sep 16, 2024 · 9a615ff · 9a615ff
1 parent 67e8680
commit 9a615ff
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/clj/com/rpl/specter/navs.cljc b/src/clj/com/rpl/specter/navs.cljc
@@ -95,6 +95,13 @@
       (comp (map next-fn)
             (filter not-NONE?))
       structure))
+
+  #?(:clj String :cljs string)
+  (all-transform [structure next-fn]
+    (apply str (into []
+                     (comp (map next-fn)
+                           (filter not-NONE?))
+                     structure)))
 
   #?(:clj clojure.lang.PersistentHashSet :cljs cljs.core/PersistentHashSet)
   (all-transform [structure next-fn]

diff --git a/test/com/rpl/specter/core_test.cljc b/test/com/rpl/specter/core_test.cljc
@@ -1440,6 +1440,15 @@
   (is (= "abq" (setval s/LAST "q" "abc")))
   )
 
+(defn whitespace? [char]
+  (re-matches #"\s" (str char)))
+
+(deftest string-transform-test
+  (is (= "123" (transform s/ALL identity "123")))
+  (is (= "123" (transform [s/ALL whitespace?] s/NONE "1 2 3")))
+  #?(:clj (is (= "123" (setval [s/ALL #(Character/isWhitespace %)] s/NONE "1 2 3"))))
+  #?(:clj (is (= "123" (transform [(s/filterer #(Character/isWhitespace %))] s/NONE "1 2 3")))))
+
 (deftest regex-navigation-test
   ;; also test regexes as implicit navs
   (is (= (select #"t" "test") ["t" "t"]))