Update contacts.js #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the regular expression in 'addContact' function to the same regular expression used in 'checkJid' function, to solve the problem of adding contact like the following: '[email protected]' (x.x.x.x = IP address).
|
@karmac2015 you are not meant to use IP addresses in XMPP IDs. Your IP does not belong to you, in might change on your ISP's whim, and everyone will not be able to contact you. That's why you should always use your own domain for your server. |
|
It is useful when trying to test the app on my own local server and I want to use an IP address instead of domain name. Why in 'checkJid' function the regular expression allows using jid with IP address, but in 'addContact' function doesn't allow ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the regular expression in 'addContact' function to the same regular expression used in 'checkJid' function, to solve the problem of adding contact like the following: '[email protected]' (x.x.x.x = IP address).