Fix timestamps in batch writing (#109)

* fix timestamps in batch writing * update CHANGELOG
reductstore · Apr 26, 2024 · cb9af9c · cb9af9c
1 parent a36fcb6
commit cb9af9c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+
+## Fixed:
+
+- Timestamps in batch writing, [PR-109](https://github.com/reductstore/reduct-py/pull/109)
+
 ## [1.9.0] - 2023-03-08
 
 ### Added:

diff --git a/reduct/record.py b/reduct/record.py
@@ -90,7 +90,7 @@ async def read_all():
             last=False,
         )
 
-        self._records[timestamp] = record
+        self._records[record.timestamp] = record
 
     def items(self) -> List[Tuple[int, Record]]:
         """Get records as dict items"""

diff --git a/tests/bucket_test.py b/tests/bucket_test.py
@@ -424,10 +424,11 @@ async def read_chunks(rec: Record):
 async def test_batched_write(bucket_1):
     """Should write batched records"""
     batch = Batch()
+    # use different timestamp formats
     batch.add(1000, b"Hey,", "plain/text", {"label1": "value1"})
-    batch.add(2000, b"how", "plain/text", {"label2": "value2"})
+    batch.add(datetime.fromtimestamp(0.002), b"how", "plain/text", {"label2": "value2"})
     batch.add(
-        3000,
+        datetime.fromtimestamp(0.003).isoformat(),
         b"are",
         "plain/text",
     )