Add external session and context manager to Client #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Feature
What is the current behavior?
We create a new session for each HTTP request. This is very inefficient.
What is the new behavior?
To avoid breaking compatibility, I've added an additional argument to constructor to pass an external
aihttp.Session
. A user can also use a context manager:Does this PR introduce a breaking change?
No
Other information: