RS-70: Optimize parsing batch records in Python SDK #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyCvn
changed the title
AnthonyCvn
changed the title
atimin
deleted the
RS-70-Optimize-parsing-batch-records-in-Python-SDK
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Optimization
What is the current behavior?
The implementation of _read_response function concatenates byte strings in a loop.
What is the new behavior?
The optimized _read_response function now uses a list to collect byte chunks and combines them at the end using join().
Does this PR introduce a breaking change?
No
Other information: