Skip to content

Remove Serialisation from useStableQueryArgs #4996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riqts
Copy link
Contributor

@riqts riqts commented May 25, 2025

Fixes #4995

I just added this code that @phryneas suggested in the discourse there, incase we wanted to run with that suggestion.
Can also read the thread there, but @EskiMojo14 raised a concern about large structures so I'll just leave this PR here incase we choose to go with it. Open to other suggestions I can spin up a PR for as well though.

Copy link

codesandbox bot commented May 25, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0d4e2e:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

netlify bot commented May 25, 2025

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit e0d4e2e
🔍 Latest deploy log https://app.netlify.com/projects/redux-starter-kit-docs/deploys/6832af198a089c0008b4eac1
😎 Deploy Preview https://deploy-preview-4996--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markerikson
Copy link
Collaborator

I'm not sure if I'm encouraged or disturbed that all the tests seem to have passed :)

@riqts
Copy link
Contributor Author

riqts commented May 25, 2025

I'm not sure if I'm encouraged or disturbed that all the tests seem to have passed :)

Exactly the thought I had 😅 😅 😅
Might take a closer look at the tests just to make sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useStableQueryArgs + defaultSerializeQueryArgs + serializeQueryArgs - avoiding attempts to serialize huge parameters
2 participants