[TS] Include query parameters in typed Cell component props #11737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When i generate any cell that needs an input for it's GQL query, the generated redwood types makes those inputs available as props on the
<…Cell>component. So far, so good, yer good 'ole Redwood magic.While authoring the cell component code however, one needs to manually extend the interfaces to get around typescript errors when accessing those props. This PR changes that.
I'd also suggest improving createCell so all components (not only
<Success>) get full type annotations & generics – so one will get best autocompletion on all components out-of-the-box – but that'd probably be a separate PR.