Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added exports to form-component props #4089

Merged
merged 2 commits into from
Jan 10, 2022
Merged

added exports to form-component props #4089

merged 2 commits into from
Jan 10, 2022

Conversation

realStandal
Copy link
Collaborator

This PR adds export statements to the prop-interfaces provided by packages/forms, making it easier to compose components which extend their functionality - or provide defaults on top of them.

@realStandal
Copy link
Collaborator Author

There are a lot of Linting errors related to prop-types. I can resolve those while I'm at it - just let me know!

@Tobbe Tobbe added the release:feature This PR introduces a new feature label Jan 9, 2022
@Tobbe
Copy link
Member

Tobbe commented Jan 9, 2022

There are a lot of Linting errors related to prop-types. I can resolve those while I'm at it - just let me know!

If you want that would be nice 🙂

@callingmedic911
Copy link
Member

@realStandal @Tobbe There's an ongoing PR by @nzdjb (and a dependency issue): #3762. Just thought to let you guys know, I think you've come across the same lint issue.

Copy link
Member

Tobbe commented Jan 9, 2022

Thanks for the heads-up @callingmedic911

@realStandal
Copy link
Collaborator Author

Hey @callingmedic911, thanks for calling that out! It does look like these warnings were introduced during the ESLint 7 to 8 upgrade, but it also looks like they should have been resolved. The warnings I'm seeing are slightly different than the ones in that PR - but they do look like they're being caused by the same change.

Seeing as the warnings are known about and being tracked, I'll leave fixing them out of this PR.

I'm happy with this PR as-is, if that's agreeable.

@Tobbe Tobbe added release:fix This PR is a fix and removed triage/processing release:feature This PR introduces a new feature labels Jan 10, 2022
@Tobbe Tobbe enabled auto-merge (squash) January 10, 2022 04:45
@Tobbe Tobbe merged commit c87fcf6 into redwoodjs:main Jan 10, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Jan 10, 2022
@realStandal realStandal deleted the rl-export-form-props branch January 10, 2022 04:53
@thedavidprice thedavidprice modified the milestones: next-release, v0.42.0 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
No open projects
Status: Archived
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants