fix(web): plugin iframe has an incorrect size

[airslice]

Overview

When auto resize base on plugin html css we don't need to take scrollbar size in consider.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

• Bug Fixes
  • Simplified the calculations for the dimensions of HTML elements, improving the resizing logic by removing the impact of scrollbars.
• Refactor
  • Enhanced the efficiency of the dimension calculations for a more straightforward implementation.

[coderabbitai]

Walkthrough

The changes in this pull request focus on simplifying the calculations for the dimensions of an HTML element in the useHook function. The previous implementation included additional factors for scrollbars, while the new version streamlines the calculations by considering only the element's offset dimensions and margins. This adjustment alters the resizing logic by excluding the influence of scrollbars.

Changes

File Path	Change Summary
web/src/beta/features/Visualizer/Crust/Plugins/PluginFrame/SafeIFrame/hooks.ts	Simplified width and height calculations by removing scrollbar dimensions.

Suggested labels

web

Suggested reviewers

• mkumbobeaty
• m-abe-dev

Poem

In the code where rabbits play,
Dimensions danced in a complex way.
With scrollbars gone, the math is clear,
A simpler path, we hold so dear!
Hops of joy, let’s celebrate,
For cleaner code, we elevate! 🐇✨

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08d5d27 and 982b7af.

Files selected for processing (1)

• web/src/beta/features/Visualizer/Crust/Plugins/PluginFrame/SafeIFrame/hooks.ts (1 hunks)

Additional comments not posted (1)

web/src/beta/features/Visualizer/Crust/Plugins/PluginFrame/SafeIFrame/hooks.ts (1)

156-157: Verify if ignoring the scrollbar dimensions aligns with the desired resizing behavior.

The simplified width and height calculations, which exclude the scrollbar dimensions, may lead to a more straightforward implementation. However, please ensure that this change aligns with the intended resizing behavior and does not introduce any undesired side effects or inaccuracies in the iframe sizing.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for reearth-web ready!

Name	Link
🔨 Latest commit	982b7af
🔍 Latest deploy log	https://app.netlify.com/sites/reearth-web/deploys/66ebec37f792780008e73055
😎 Deploy Preview	https://deploy-preview-1149--reearth-web.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.