Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): update preset layer style hideIndicator setting #1164

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

lavalse
Copy link
Member

@lavalse lavalse commented Oct 2, 2024

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

  • New Features

    • Updated styles for various map layers, enhancing visual customization options.
  • Bug Fixes

    • The indicator for professionalStyle, polylineStyle, polygonStyle, and extrudedPolygonStyle is now hidden for a cleaner appearance.
  • Improvements

    • Changed the fill color of the professionalStyle polygon for better visual distinction.

Copy link

coderabbitai bot commented Oct 2, 2024

Walkthrough

The changes involve modifications to the presetLayerStyles.ts file, specifically adjusting the properties of several style objects: professionalStyle, polylineStyle, polygonStyle, and extrudedPolygonStyle. The hideIndicator property for these styles has been set to true, indicating that indicators will be hidden. Additionally, the fillColor property in the professionalStyle has been updated to a new color expression. The overall structure of the style definitions remains unchanged.

Changes

File Path Change Summary
web/src/beta/features/Editor/Map/LayerStylePanel/PresetLayerStyle/presetLayerStyles.ts Modified hideIndicator to true for multiple styles and updated fillColor for professionalStyle.

Possibly related PRs

  • feat(web): preset layer style #1156: This PR involves changes to the presetLayerStyles.ts file, which directly relates to the modifications made to the professionalStyle, polylineStyle, polygonStyle, and extrudedPolygonStyle objects in the main PR.

Suggested reviewers

  • mkumbobeaty
  • airslice

Poem

In the layers where styles do play,
Indicators now hide away.
With colors bright, our map will glow,
A new design for all to show!
Hop along, let’s celebrate,
Style updates that look so great! 🐰✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 57d0810 and bcd8d7c.

📒 Files selected for processing (1)
  • web/src/beta/features/Editor/Map/LayerStylePanel/PresetLayerStyle/presetLayerStyles.ts (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/src/beta/features/Editor/Map/LayerStylePanel/PresetLayerStyle/presetLayerStyles.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the web label Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit bcd8d7c
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/66fcd29651603300089dac9e
😎 Deploy Preview https://deploy-preview-1164--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@airslice airslice changed the title feat(web): update preset professional layer style hideIndicator setting feat(web): update preset layer style hideIndicator setting Oct 2, 2024
@lavalse lavalse merged commit dedecd9 into main Oct 2, 2024
16 of 17 checks passed
@lavalse lavalse deleted the fix/preset-professional-style branch October 2, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants