Chore(web): Add ImageBlock #511
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 26.65% 27.10% +0.44%
==========================================
Files 1342 1321 -21
Lines 144699 142442 -2257
Branches 3485 3542 +57
==========================================
+ Hits 38571 38602 +31
+ Misses 105005 102791 -2214
+ Partials 1123 1049 -74
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| type Props = { | ||
| src: NonNullable<ImgHTMLAttributes<HTMLImageElement>["src"]>; | ||
| align?: "left" | "center" | "right"; // default center |
There was a problem hiding this comment.
You shouldn't need the comments here in the props.
Can you
- remove the comments
- Inside the props destructuring(line 15) assign defaults (ie.
({src, align="center", fit="cover", .. .. . .. }) - Lastly update the styled component's props to expect a value for fit and align always and remove the fallbacks
There was a problem hiding this comment.
The code has changed.
�Above code no longer exists.
# Conflicts: # web/src/beta/components/Icon/icons.ts
| if (src) { | ||
| return ( |
There was a problem hiding this comment.
Like the Video block , please use a ternary operator with one return 🙇🏻
| } | ||
| return ( | ||
| <BlankImageBox> | ||
| <Icon icon={"image"} color={"#2e2e2e"} size={32} /> |
There was a problem hiding this comment.
Don't need { } for strings
so icon="image" color="#2e2e2e"
| }; | ||
|
|
||
| const Wrapper = styled.div` | ||
| position: absolute; |
| src: NonNullable<React.ImgHTMLAttributes<HTMLImageElement>["src"]>; | ||
| alt?: React.ImgHTMLAttributes<HTMLImageElement>["alt"]; |
There was a problem hiding this comment.
You don't need to type so specifically. For some elements, where there are specific values needed, this is good.
But for something like src and alt, any string is okay, so you can just type these as string
Overview
Add ImageBlock
https://deploy-preview-511--reearth-web.netlify.app/storybook/?path=/story/beta-components-blocks-imageblock--default