-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(web): Add ImageBlock #511
Closed
+85
−0
Closed
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cf0b930
Chore(web): Add ImageBlock
FabPARKJAESUNG 1b61090
Fix(web): Delete unnecessary parts
FabPARKJAESUNG af5f733
Merge branch 'main' into feature/PASONA_PLATEAU-37
FabPARKJAESUNG c8dcf8a
Fix(web): render to args
FabPARKJAESUNG 0b87da1
Fix(web): Modification by feedback
FabPARKJAESUNG 6fbb88a
Merge branch 'main' into feature/PASONA_PLATEAU-37
b6192df
Merge branch 'main' into feature/PASONA_PLATEAU-37
FabPARKJAESUNG 867c535
Chore(web): Add ImageBlock Component
FabPARKJAESUNG f7534d4
Merge branch 'main' into feature/PASONA_PLATEAU-37
e914ffe
Fix(web): Modification by feedback
FabPARKJAESUNG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
web/src/beta/components/Blocks/ImageBlock/index.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { Meta, StoryObj } from "@storybook/react"; | ||
|
||
import ImageBlock from "."; | ||
|
||
export default { | ||
component: ImageBlock, | ||
} as Meta; | ||
|
||
type Story = StoryObj<typeof ImageBlock>; | ||
|
||
export const Default: Story = { | ||
args: { | ||
src: "http://placehold.it/150X150", | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import { CSSProperties, FC, ImgHTMLAttributes } from "react"; | ||
|
||
import { styled } from "@reearth/services/theme"; | ||
|
||
type Props = { | ||
src: NonNullable<ImgHTMLAttributes<HTMLImageElement>["src"]>; | ||
align?: "left" | "center" | "right"; // default center | ||
fit?: "contain" | "cover"; // default cover | ||
maxHeight?: CSSProperties["maxHeight"]; | ||
alt?: ImgHTMLAttributes<HTMLImageElement>["alt"]; | ||
height?: CSSProperties["width"]; | ||
width?: CSSProperties["height"]; | ||
}; | ||
|
||
const ImageBlock: FC<Props> = ({ src, align, fit, maxHeight, alt, width, height }) => { | ||
return ( | ||
<Wrapper> | ||
<ImageBox | ||
src={src} | ||
fit={fit} | ||
alt={alt} | ||
maxHeight={maxHeight} | ||
width={width} | ||
height={height} | ||
align={align} | ||
/> | ||
</Wrapper> | ||
); | ||
}; | ||
|
||
const Wrapper = styled.div` | ||
position: absolute; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't think you need this |
||
display: flex; | ||
`; | ||
|
||
const ImageBox = styled.img<{ | ||
fit?: "contain" | "cover"; | ||
maxHeight?: CSSProperties["maxHeight"]; | ||
align?: "left" | "center" | "right"; | ||
}>` | ||
display: flex; | ||
object-fit: ${props => (props.fit ? props.fit : "cover")}; | ||
width: ${props => (props.width ? props.width : undefined)}; | ||
height: ${props => (props.height ? props.height : undefined)}; | ||
max-height: ${props => (props.maxHeight ? props.maxHeight : undefined)}; | ||
object-position: ${props => (props.align ? props.align : "center")}; | ||
`; | ||
|
||
export default ImageBlock; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need the comments here in the props.
Can you
({src, align="center", fit="cover", .. .. . .. })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code has changed.
�Above code no longer exists.