-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): support with Authentication function support for cognito backend #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #514 +/- ##
==========================================
- Coverage 27.32% 27.32% -0.01%
==========================================
Files 1345 1345
Lines 144958 144972 +14
Branches 3541 3541
==========================================
+ Hits 39605 39607 +2
- Misses 104201 104213 +12
Partials 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nina992
approved these changes
Jun 23, 2023
KaWaite
reviewed
Jun 26, 2023
KaWaite
reviewed
Jun 26, 2023
nina992
approved these changes
Jul 4, 2023
KaWaite
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for withAuthentication function support for backend which is using cognito.
What I've done
I've added
withAuthentication
function for cognito based authentication mode.How I tested
Fire-up local using cognito authentication provider and try to copy the url of the
earthEditor
or any page which required Authentication and use it in incognito mode. If it redirects to login page of cognito then its working.