-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): add image-based lighting #519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reearth-web canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
========================================
Coverage 28.48% 28.49%
========================================
Files 1392 1392
Lines 150120 150308 +188
Branches 3591 3590 -1
========================================
+ Hits 42769 42837 +68
- Misses 106199 106319 +120
Partials 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more.
|
airslice
changed the title
feat(web): add image-based lighting
chore(web): add image-based lighting
Jul 12, 2023
keiya01
reviewed
Jul 12, 2023
keiya01
reviewed
Jul 12, 2023
Co-authored-by: keiya sasaki <[email protected]>
pyshx
approved these changes
Jul 13, 2023
keiya01
reviewed
Jul 14, 2023
keiya01
reviewed
Jul 14, 2023
keiya01
reviewed
Jul 14, 2023
keiya01
reviewed
Jul 14, 2023
keiya01
reviewed
Jul 14, 2023
keiya01
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Supports image-based lighting for beta.
What I've done
Add image based lighting properties to scene, which should effect PBR models & 3d tiles in scene:
Add image based lighting properties to 3d tiles appearance & model appearance
What I haven't done
How I tested
Scene IBL
3d tiles IBL
Model IBL
Which point I want you to review particularly
Memo
undefined
can be used.undefined
will be ignored.