Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): handle GQL errors w useSetAtom #528

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

KaWaite
Copy link
Member

@KaWaite KaWaite commented Jun 28, 2023

Overview

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit b6f8a9b
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/649bc0bf7bf0060008addf9d
😎 Deploy Preview https://deploy-preview-528--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #528 (354067a) into main (d342489) will increase coverage by 0.03%.
The diff coverage is 64.70%.

❗ Current head 354067a differs from pull request most recent head b6f8a9b. Consider uploading reports for the commit b6f8a9b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
+ Coverage   26.66%   26.69%   +0.03%     
==========================================
  Files        1340     1338       -2     
  Lines      144638   144449     -189     
  Branches     3484     3481       -3     
==========================================
+ Hits        38561    38567       +6     
+ Misses     104955   104760     -195     
  Partials     1122     1122              
Flag Coverage Δ
web 24.04% <64.70%> (+0.04%) ⬆️
web-beta 24.04% <64.70%> (+0.04%) ⬆️
web-classic 24.04% <64.70%> (+0.04%) ⬆️
web-utils 24.04% <64.70%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/services/gql/provider.tsx 15.67% <25.00%> (+0.28%) ⬆️
web/src/services/state/gqlErrorHandling.ts 75.00% <75.00%> (ø)
web/src/services/state/index.ts 93.47% <100.00%> (-0.10%) ⬇️

... and 6 files with indirect coverage changes

@KaWaite KaWaite merged commit ff20402 into main Jun 28, 2023
@KaWaite KaWaite deleted the refactor-network-error-handling branch June 28, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants