Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add container settings panel for widget area #620

Merged
merged 9 commits into from
Aug 10, 2023

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Aug 3, 2023

Overview

Add container settings panel for widget area.

What I've done

What I haven't done

Property item is not included in this PR.

How I tested

localhost_3000_scene_01h6nc8v95agckw8nvtxd7pcy9_widgets(Desktop 1920) (1)

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Aug 3, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5f4fc08
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64d437c4e63ebb0008342c92
😎 Deploy Preview https://deploy-preview-620--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #620 (5f4fc08) into main (17b2566) will decrease coverage by 0.03%.
The diff coverage is 2.99%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   28.43%   28.41%   -0.03%     
==========================================
  Files        1456     1457       +1     
  Lines      158419   158564     +145     
  Branches     3763     3764       +1     
==========================================
+ Hits        45047    45051       +4     
- Misses     112215   112356     +141     
  Partials     1157     1157              
Flag Coverage Δ
web 26.49% <2.99%> (-0.03%) ⬇️
web-beta 26.49% <2.99%> (-0.03%) ⬇️
web-classic 26.49% <2.99%> (-0.03%) ⬇️
web-utils 26.49% <2.99%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/beta/components/SidePanelSectionField/index.tsx 0.00% <0.00%> (ø)
...eta/features/Editor/Visualizer/CanvasArea/hooks.ts 0.00% <0.00%> (ø)
...rc/beta/features/Editor/tabs/widgets/Nav/index.tsx 0.00% <0.00%> (ø)
...tabs/widgets/SidePanel/ContainerSettings/index.tsx 0.00% <0.00%> (ø)
...ta/features/Editor/tabs/widgets/SidePanel/hooks.ts 0.00% <0.00%> (ø)
...a/features/Editor/tabs/widgets/SidePanel/index.tsx 0.00% <0.00%> (ø)
.../lib/core/Crust/Widgets/WidgetAlignSystem/Area.tsx 0.00% <0.00%> (ø)
web/src/services/api/widgetsApi/index.ts 22.08% <10.00%> (-0.37%) ⬇️
web/src/services/state/index.ts 100.00% <100.00%> (ø)

@airslice airslice marked this pull request as ready for review August 3, 2023 05:18
@github-actions github-actions bot requested a review from nina992 August 3, 2023 05:18
@airslice airslice merged commit bea6686 into main Aug 10, 2023
16 checks passed
@airslice airslice deleted the chore/add-was-container-settings-panel branch August 10, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants