-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): Toggle Field #651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minor fixes in stories left
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Some story styling fixes
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
=======================================
Coverage 27.42% 27.43%
=======================================
Files 1512 1513 +1
Lines 164354 164343 -11
Branches 3840 3841 +1
=======================================
Hits 45080 45080
+ Misses 118186 118175 -11
Partials 1088 1088
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nina992
approved these changes
Aug 30, 2023
KaWaite
reviewed
Aug 31, 2023
web/src/beta/features/Editor/tabs/publish/Nav/PublishModal/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
reviewed
Aug 31, 2023
KaWaite
reviewed
Aug 31, 2023
KaWaite
reviewed
Aug 31, 2023
- Exported prop from the component
KaWaite
reviewed
Aug 31, 2023
KaWaite
reviewed
Aug 31, 2023
web/src/beta/features/Editor/tabs/publish/Nav/PublishModal/index.tsx
Outdated
Show resolved
Hide resolved
KaWaite
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Toggle Field implementation
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo