Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Toggle Field #651

Merged
merged 12 commits into from
Aug 31, 2023
Merged

feat(web): Toggle Field #651

merged 12 commits into from
Aug 31, 2023

Conversation

jashanbhullar
Copy link
Contributor

@jashanbhullar jashanbhullar commented Aug 30, 2023

Overview

Toggle Field implementation

What I've done

  • basic toggle component
  • Toggle field property

What I haven't done

  • NA

How I tested

  • stories

Which point I want you to review particularly

  • onChange method
  • styling
  • Property field integration

Memo

- Minor fixes in stories left
@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 4b17091
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f026f6f8dc0400083af060
😎 Deploy Preview https://deploy-preview-651--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 30, 2023
@jashanbhullar jashanbhullar marked this pull request as ready for review August 30, 2023 06:47
@github-actions github-actions bot requested a review from nina992 August 30, 2023 06:47
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #651 (4b17091) into main (0eaeed2) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   27.42%   27.43%           
=======================================
  Files        1512     1513    +1     
  Lines      164354   164343   -11     
  Branches     3840     3841    +1     
=======================================
  Hits        45080    45080           
+ Misses     118186   118175   -11     
  Partials     1088     1088           
Flag Coverage Δ
web 25.76% <0.00%> (+<0.01%) ⬆️
web-beta 25.76% <0.00%> (+<0.01%) ⬆️
web-classic 25.76% <0.00%> (+<0.01%) ⬆️
web-utils 25.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
web/src/beta/components/Toggle/index.tsx 0.00% <0.00%> (ø)
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
...b/src/beta/components/fields/ToggleField/index.tsx 0.00% <0.00%> (ø)
...res/Editor/tabs/publish/Nav/PublishModal/index.tsx 0.00% <0.00%> (ø)
...rc/beta/features/Editor/tabs/widgets/Nav/index.tsx 0.00% <0.00%> (ø)

@jashanbhullar jashanbhullar merged commit b13b187 into main Aug 31, 2023
16 checks passed
@jashanbhullar jashanbhullar deleted the feat/web/fields/toggle branch August 31, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants