Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): Add layers from local #702

Merged
merged 36 commits into from
Oct 2, 2023
Merged

chore(web): Add layers from local #702

merged 36 commits into from
Oct 2, 2023

Conversation

mkumbobeaty
Copy link
Contributor

@mkumbobeaty mkumbobeaty commented Sep 22, 2023

Overview

What I've done

  • Add layer from local assets in common and csv component
  • improve file-constant to accept csv format on upload

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for reearth-web canceled.

Name Link
🔨 Latest commit f9cc48a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/651a5d71dc93070008336ef3

@github-actions github-actions bot added the web label Sep 22, 2023
@mkumbobeaty mkumbobeaty changed the title Chore/layers Chore(web)/layers Sep 22, 2023
@mkumbobeaty mkumbobeaty changed the title Chore(web)/layers Chore(web)/Add-layers Sep 22, 2023
@mkumbobeaty mkumbobeaty changed the title Chore(web): Add layers from local chore(web): Add layers from local Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #702 (f9cc48a) into main (db2564c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   26.71%   26.70%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      171271   171317      +46     
  Branches     3898     3898              
==========================================
+ Hits        45754    45756       +2     
- Misses     124428   124472      +44     
  Partials     1089     1089              
Flag Coverage Δ
web 25.00% <0.00%> (-0.01%) ⬇️
web-beta 25.00% <0.00%> (-0.01%) ⬇️
web-classic 25.00% <0.00%> (-0.01%) ⬇️
web-utils 25.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Assets/constants.ts 0.00% <0.00%> (ø)
...res/Editor/DataSourceManager/VectorTiles/index.tsx 0.00% <0.00%> (ø)
...atures/Editor/DataSourceManager/WmsTiles/index.tsx 0.00% <0.00%> (ø)
...c/beta/features/Editor/DataSourceManager/index.tsx 0.00% <0.00%> (ø)
...s/Editor/DataSourceManager/DelimitedText/index.tsx 0.00% <0.00%> (ø)
.../features/Editor/DataSourceManager/Asset/index.tsx 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@mkumbobeaty mkumbobeaty marked this pull request as ready for review September 26, 2023 13:40
@mkumbobeaty mkumbobeaty merged commit a4a580e into main Oct 2, 2023
15 checks passed
@mkumbobeaty mkumbobeaty deleted the chore/layers branch October 2, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants