Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add scene setting #755

Merged
merged 20 commits into from
Nov 6, 2023
Merged

chore(web): add scene setting #755

merged 20 commits into from
Nov 6, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Oct 23, 2023

Overview

Add Scene Setting to the Editor for beta Project

What I've done

image
image
image
image
image
image
image

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Design Link : https://www.figma.com/file/W6nDSiCBLubcNeAT6RkOoa/%E2%AD%90%E2%AD%90%E2%AD%90Re%3AEarth-Beta-Design-system?type=design&node-id=2811-10042&mode=design&t=D9eWg6IuRUjYq5nh-0

@nina992 nina992 requested a review from KaWaite as a code owner October 23, 2023 06:57
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 3a984c2
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/65488cc192fb7f0008512867
😎 Deploy Preview https://deploy-preview-755--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #755 (3a984c2) into main (56c4c00) will decrease coverage by 0.01%.
The diff coverage is 7.16%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   25.97%   25.97%   -0.01%     
==========================================
  Files        1629     1630       +1     
  Lines      177980   178051      +71     
  Branches     3912     3913       +1     
==========================================
+ Hits        46227    46243      +16     
- Misses     130664   130719      +55     
  Partials     1089     1089              
Flag Coverage Δ
server 33.37% <ø> (ø)
web 24.23% <7.16%> (-0.01%) ⬇️
web-beta 24.23% <7.16%> (-0.01%) ⬇️
web-classic 24.23% <7.16%> (-0.01%) ⬇️
web-utils 24.23% <7.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
web/src/beta/features/Editor/hooks.ts 0.00% <ø> (ø)
...a/lib/core/StoryPanel/Block/builtin/Text/index.tsx 0.00% <ø> (ø)
web/src/beta/features/ProjectSettings/hooks.ts 0.00% <0.00%> (ø)
web/src/beta/lib/core/Crust/context.ts 0.00% <0.00%> (ø)
...b/core/StoryPanel/Block/builtin/common/Wrapper.tsx 0.00% <0.00%> (ø)
web/src/beta/lib/core/StoryPanel/Page/index.tsx 0.00% <0.00%> (ø)
web/src/services/api/sceneApi.ts 60.75% <95.23%> (+13.98%) ⬆️
web/src/beta/lib/core/Visualizer/index.tsx 0.00% <0.00%> (ø)
web/src/beta/pages/Page.tsx 0.00% <0.00%> (ø)
web/src/services/api/propertyApi/utils.ts 42.85% <33.33%> (+0.04%) ⬆️
... and 13 more

... and 4 files with indirect coverage changes

@KaWaite KaWaite requested a review from pyshx as a code owner November 4, 2023 01:52
@github-actions github-actions bot added the server label Nov 4, 2023
@KaWaite KaWaite requested a review from keiya01 as a code owner November 6, 2023 06:50
@KaWaite KaWaite merged commit f9e53a5 into main Nov 6, 2023
16 of 17 checks passed
@KaWaite KaWaite deleted the chore/scene-properties branch November 6, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants