-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web, server): add migration for ga support #981
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for reearth-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI Lint is failing.
|
||
var seeds []seed | ||
|
||
col.Find(ctx, bson.M{}, &mongox.BatchConsumer{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of just logging errors, consider returning them from the CopySceneId function. This will allow the caller to handle errors appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 634a084
79d81b0
to
a40485c
Compare
Overview
What I've done
implement a migration for ga
What I haven't done
How I tested
created migration test case
Which point I want you to review particularly
Memo