Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated call to Aws::CredentialProvider access_key_id #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PlugIN73
Copy link

This @s3.client.config.credentials is SharedCredentials, which included methods from CredentialProvider:
http://docs.aws.amazon.com/sdkforruby/api/Aws/CredentialProvider.html#access_key_id-instance_method

Instead this methods, we must use this methods from Credentials module:
http://docs.aws.amazon.com/sdkforruby/api/Aws/Credentials.html#access_key_id-instance_method

@PlugIN73
Copy link
Author

to issue #18

@trendwithin
Copy link

By chance is this related to the following error I'm getting when I start up the server?

/usr/local/lib/ruby/gems/2.2.0/gems/refile-s3-0.2.0/lib/refile/s3.rb:43:in `initialize': missing keywords: region, bucket (ArgumentError)

@PlugIN73
Copy link
Author

PlugIN73 commented Dec 3, 2015

@trendwithin you just did't configure params region, bucket
You need do like this:

Refile::S3.new(your_current_params, region: "eu-west-1", bucket: "my_s3_bucket")

@trendwithin
Copy link

Thanks for the reply. I was able to pinpoint the error I made. I was following the set-up example a tad too literally and made the mistake of:

Refile.cache = Refile::S3.new(prefix: "cache", **aws)
Refile.cache = Refile::S3.new(max_size: 10.megabytes)
Refile.store = Refile::S3.new(prefix: "store", **aws)

instead of

 Refile.cache = Refile::S3.new(prefix: "cache", max_size: 10.megabytes, **aws)
 Refile.store = Refile::S3.new(prefix: "store", **aws)   

fran-worley added a commit to SafetyToolbox/refile-s3 that referenced this pull request Dec 23, 2015
1)add acl option to initialise method and use in available calls
defaults to ‘public-read’ so backwards compatible, but enables people
to make private as desired.
2) also included deprecation fix from PR refile#18
3) added success_action_status: 201 to presign method to fix firefox
xml parse error:
XML Parsing Error: no element found Location:
moz-nullprincipal:{28d28eb9-bcef-f842-8355-54e833de9cd1} Line Number 1,
Column 1:
@PlugIN73
Copy link
Author

@jnicklas what do you think?

@crhonox
Copy link

crhonox commented Nov 4, 2021

Anyone managed to use iam roles credential in a ecs container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants