Support Rails 6 and 7 on Ruby 3 #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ActiveRecord::Persistence#update_attributes` method got removed after Rails 5. So in order to make the pieces of code that use it on Rails 6 and 7, those calls needed to be replaced by their correspondent method, `ActiveRecord::Persistence#update`.
It turns out that the middlewares that are being deleted there don't exist already on Rails 7, so it'd raise an error when trying to delete them on Rails 7.
It's necessary in order to make JS assets to be loaded properly in the Capybara related tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #614.