Mccalluc/remove old bits #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmarx
reviewed
Sep 24, 2018
| root_label, | ||
| client=docker.from_env(), | ||
| pem=None, | ||
| ssh_username=None | ||
| ): | ||
| """ | ||
| :param string data_dir: Only needed if input is passed as file. |
tests/test_docker_utils.py
Outdated
| 'container_input_path': '/usr/share/nginx/html/index.html' | ||
| }).url | ||
| self.assert_loads_eventually(url, '{"foo": "bar"}') | ||
| # TODO: We're no longer writing the input straight to disk: |
There was a problem hiding this comment.
If you're getting to it soon, no worries but if not on immediate radar shift to an issue.
scottx611x
approved these changes
Sep 24, 2018
Closed
scottx611x
added a commit
to refinery-platform/refinery-platform
that referenced
this pull request
Oct 24, 2018
scottx611x
added a commit
to refinery-platform/refinery-platform
that referenced
this pull request
Nov 2, 2018
* Add engine_version var and set default to 10.4; We are targeting the latest available Postgres engine version provided by AWS RDS at the moment * Specify exact Postresql versions to target for Aws and Vagrant deployments; When specifying `manage_package_repo`, setting version to `10.4` will fail. Postgres version schem has changed and specifying 10 will fetch the latest point release. * Specify Travis addons, packages, and envvar for postgres-10 * I think we can still use the standard port * Remove unnecessary commands Ref: #3047, refinery-platform/django_docker_engine#195 * Remove `docker` from services as Travis-CI provides this already nowadays * Remove redundant declaration of postgresql service * Specify PGPORT as global build envvar * Use default postgres port on Travis * Remove neo4j service declaration * Add known workaround to be able to use the default PostgreSQL port on Travis-CI; See: travis-ci/travis-ci#8537 (comment) * Use older postgres auth config * Specify PostgreSQL 10 in postgresql.pp [skip ci] * specify `manage_package_repo` in AWS `::postgresql::globals` as well [skip ci] * Add rds_engine_version as a temporary configurable, and set default to 10.5; PostgreSQL 10.5 is the current latest AWS supported engine at the moment of typing this * Replace `rds_engine_version` variable with hardcoded value * Specify postgres 10 in aws.sh script * Remove postgresql-client library installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this began there were three ways of providing input: The environment variables INPUT_JSON and INPUT_JSON_URL, but a third option was writing directly to a mounted file system. We never used this in production, and it added a lot of complexity to the code base.