Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent homepage with locale in path to be duplicated #3298

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bricesanchez
Copy link
Member

No description provided.

@bricesanchez bricesanchez changed the title Prevent homepage with locale in path to be duplicate Prevent homepage with locale in path to be duplicated Jul 8, 2017
@parndt
Copy link
Member

parndt commented Jul 9, 2017

@bricesanchez
Copy link
Member Author

Yes, we should! I thinking of changing the way we generate sitemap in order to handle engines records

@bricesanchez bricesanchez force-pushed the bugfix/sitemap-multiple-langs branch from bd5a019 to 6df043d Compare July 10, 2017 01:42
@bricesanchez bricesanchez self-assigned this Aug 14, 2017
@@ -17,7 +17,7 @@ xml.urlset "xmlns" => "http://www.sitemaps.org/schemas/sitemap/0.9" do
# handle relative link_url addresses.
raw_url = [request.protocol, request.host_with_port, page.url].join

if (@locales.size > 1) && !page.url.start_with?("/#{locale}/") && defined?(RoutingFilter::RefineryLocales)
if (@locales.size > 1) && !page.url.start_with?("/#{locale}") && !!defined?(RoutingFilter::RefineryLocales)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the !! add here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants