-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby3 #3518
base: main
Are you sure you want to change the base?
Ruby3 #3518
Conversation
Ruby 3.1.2 core: TranslationHelper, SiteBarHelper - using Ruby3 keyword args lib/refinery/engine uses new mobility configuration images, resources: Updated examples to pass an explicit block to 'expect' as passing an implicit block is deprecated. images: Use errors.add to add errors to an object - had already been done for resources. Gem versions changed: mobility 1.2.9 rspec-rails 6.0.0.rc1 friendly_id >= 5.4.0 friendly_id-mobility ~> 1.0.3
…ms-i18n in Gemfile'
Tests failing:I have seen some of these errors during testing, but thought I was past them. Many seem to be timeouts, and then the reporting of timeouts seems to be a problem too. There are many variations of:
and I saw some other reporting of timeouts on Also frequently seen (below), which seems to be an error reporting timeouts. It occurs every minute during a run.
|
…e and Directory matchers.
Tidy up configuration block for Mobility 1.2.9 Revert some changes for single argument keyword args Add descriptions for Generator spec matchers (thereby avoiding a very long message when there are no descriptions).
Thank you for looking at this |
Is there any update on the status of this PR? I need to upgrade to ruby 3.2.1 and rails 6.x because I need to upgrade to the newest cflinux4 buildpack and no previous versions of ruby are supported. I currently use refinerycms with ruby 2.5.5 and rails 5.x. I think this merge will help me upgrade to the versions of ruby and rails mentioned above. Thank you. |
@@ -97,3 +97,4 @@ Gemfile.lock | |||
|
|||
# rspec failures | |||
.rspec_failures | |||
Refinery Review.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refinery Review.md |
@pdornfel I'd really love to merge this but CI isn't happy. The corresponding PR for refinerycms-i18n is failing on Ruby 3.0 and 3.2, but not 3.1 🤔 refinery/refinerycms-i18n#104 Any help you or anyone else can lend with figuring out why this is happening would be greatly appreciated. Right now, I suspect the routing-filter gem we use. |
Merge refinery fixes
This PR (and its matching PR on https://github.com/refinery/refinerycms-i18n ) allow
refinerycms
to run with Ruby 3.It has been tested with Ruby 3.1.2 and Rails 6.1.6.1
Will shortly be tested on Rails 7.
One test failure on /resources, which I haven't been able to fathom.