Audit revisions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitlens
approved these changes
Jan 24, 2024
orbitlens
approved these changes
Feb 1, 2024
dmkozh
reviewed
Feb 7, 2024
| @@ -280,6 +286,9 @@ impl PriceOracleContract { | |||
| admin.require_auth(); | |||
| if e.is_initialized() { | |||
| e.panic_with_error(Error::AlreadyInitialized); | |||
| } | |||
| if admin != config.admin { | |||
There was a problem hiding this comment.
Passing-by comment/recommendation from a Soroban dev: in order to avoid such errors and make a contract a tiny bit cheaper you could just remove admin from the function arguments and call config.admin.require_auth() instead. The same applies to all the similar functions that use admin - instead of passing it externally you could just retrieve admin from storage and call require_auth for it directly.
There was a problem hiding this comment.
Thanks! We've incorporated these changes in pull request #9. Appreciate your advice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timestamp validation added on set price
has_asset replaced with get_asset_index
config.admin auth check
return None as last price, if price update delayed; prices fn refactoring
updates length validation added