Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customer data app first version #194

Merged
merged 7 commits into from
Apr 3, 2024
Merged

customer data app first version #194

merged 7 commits into from
Apr 3, 2024

Conversation

tgberkeley
Copy link
Collaborator

No description provided.

Copy link
Contributor

@martinxu9 martinxu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this app ready for review? Or you plan to come back to it later @tgberkeley

@Alek99
Copy link
Member

Alek99 commented Apr 2, 2024

Screenshot 2024-04-02 at 3 57 36 PM

The modal stays white in dark mode
Screenshot 2024-04-02 at 3 57 56 PM

Also on a smaller screen size it doesn't center correctly

@tgberkeley
Copy link
Collaborator Author

Created an issue for the light and dark mode issue

@Alek99 Alek99 self-requested a review April 3, 2024 20:54
@tgberkeley tgberkeley merged commit dbc214d into main Apr 3, 2024
3 of 18 checks passed
@masenf
Copy link
Collaborator

masenf commented Apr 9, 2024

why did we merge with broken CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants