Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoded state name for 0.5.7 compatibility #249

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Avoid hardcoded state name for 0.5.7 compatibility #249

merged 1 commit into from
Aug 27, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Jul 29, 2024

No description provided.

picklelo
picklelo approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure why counter test is failing

@masenf masenf merged commit 1b59d11 into main Aug 27, 2024
22 of 24 checks passed
@masenf masenf deleted the masenf/chatroom-state-name branch August 27, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masenf @picklelo