Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more type annotations through the code #4401

Merged
merged 24 commits into from
Jan 29, 2025
Merged

add more type annotations through the code #4401

merged 24 commits into from
Jan 29, 2025

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Nov 20, 2024 •
edited
Loading

Fixes based on rules ANN001 from ruff

masenf
masenf reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially looks fine, but I don't want to bring it in for 0.6.6; lets cut the release branch then we can bring this into main and get some runtime on it.

@Lendemor
Copy link
Collaborator Author

Superficially looks fine, but I don't want to bring it in for 0.6.6; lets cut the release branch then we can bring this into main and get some runtime on it.

Sounds good, no hurry to merge this one 👍

adhami3310
adhami3310 reviewed Jan 22, 2025
View reviewed changes
reflex/vars/base.py Outdated Show resolved Hide resolved
adhami3310
adhami3310 previously approved these changes Jan 24, 2025
View reviewed changes
@Lendemor Lendemor merged commit b8b3f89 into main Jan 29, 2025
37 checks passed
@Lendemor Lendemor deleted the lendemor/improve_typings branch January 29, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf left review comments

@benedikt-bartscher benedikt-bartscher benedikt-bartscher left review comments

@adhami3310 adhami3310 adhami3310 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lendemor @masenf @adhami3310 @benedikt-bartscher