Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't memoize tooltip children #4744

Merged
merged 2 commits into from
Feb 4, 2025
Merged

don't memoize tooltip children #4744

merged 2 commits into from
Feb 4, 2025

Conversation

adhami3310
Copy link
Member

Fixes #3278

Copy link

codspeed-hq bot commented Feb 4, 2025

CodSpeed Performance Report

Merging #4744 will not alter performance

Comparing don't-memoize-tooltip-children (9f138c1) with main (20e8b83)

Summary

✅ 1 untouched benchmarks

masenf
masenf previously approved these changes Feb 4, 2025
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the @masenf stamp of approval 🥾

@masenf masenf merged commit c3ac051 into main Feb 4, 2025
39 checks passed
@masenf masenf deleted the don't-memoize-tooltip-children branch February 4, 2025 18:59
masenf added a commit that referenced this pull request Feb 5, 2025
* don't memoize tooltip children

* Skip memoizing skeleton children

---------

Co-authored-by: Masen Furer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rx.tooltip doesn't work with rx.button when that rx.button has additional properties
2 participants