Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve foreach behavior with strings #4751

Merged
merged 4 commits into from
Feb 6, 2025
Merged

improve foreach behavior with strings #4751

merged 4 commits into from
Feb 6, 2025

Conversation

adhami3310
Copy link
Member

No description provided.

@linear Linear
Copy link

linear bot commented Feb 5, 2025

ENG-4586 Foreach does not infer types for literal constants

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #4751 will not alter performance

Comparing khaleel/eng-4586-foreach-does-not-infer-types-for-literal-constants (3596211) with main (ab558ce)

Summary

✅ 8 untouched benchmarks

masenf
masenf reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for the string case in test_var_operations.py

Lendemor
Lendemor previously approved these changes Feb 6, 2025
View reviewed changes
@adhami3310 adhami3310 requested a review from Lendemor February 6, 2025 18:12
@adhami3310 adhami3310 merged commit b3b79a6 into main Feb 6, 2025
39 checks passed
@adhami3310 adhami3310 deleted the khaleel/eng-4586-foreach-does-not-infer-types-for-literal-constants branch February 6, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf left review comments

@Lendemor Lendemor Lendemor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adhami3310 @masenf @Lendemor