-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with ghc(js) 9.8.2 + 9.10.1 #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymeister
force-pushed
the
ghc(js)-9.10
branch
2 times, most recently
from
August 4, 2024 19:23
4c97ed9
to
a6c3586
Compare
alexfmpe
reviewed
Aug 5, 2024
alexfmpe
reviewed
Aug 5, 2024
ymeister
requested review from
alexfmpe,
ryantrinkle and
ali-abrar
and removed request for
alexfmpe
August 7, 2024 03:44
6 tasks
Ericson2314
reviewed
Sep 12, 2024
systems = ["x86_64-linux" "x86_64-darwin"]; | ||
systems = ["x86_64-linux"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bummer, but I think it is fine for now because https://ci.obsidian.systems/ is in maintenance mode, and other things (like reflex itself) will get this.
Ericson2314
approved these changes
Sep 12, 2024
This was referenced Sep 12, 2024
Closed
Ericson2314
reviewed
Sep 12, 2024
Ericson2314
added a commit
that referenced
this pull request
Sep 12, 2024
1. Restore a `Data.Semigroup.Commutative` reexport accidentally removed in #56. (I accidentally forgot to notice during review.) 2. Replace partial `Map.lookup` with proper custom error for internal error. (This would make debugging a bug in the implementation easier.) This was part of #55. Co-Authoredy-By: Dmitry Olshansky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
haskell.nix
:default.nix
:shell.nix
:For
nixpkgs
:When building on ghc js, requires single-core building (https://gitlab.haskell.org/ghc/ghc/-/issues/25083#note_578275).