-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add traverseFactorableSumWithAdjust
and networkHoldFactorableSum
#212
Open
Ericson2314
wants to merge
4
commits into
develop
Choose a base branch
from
factorable-sum
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they avoid the samples of `factorDyn` by embracing the `widgetHold` pattern. I am 100% cargo culting names here.
alexfmpe
reviewed
Jul 28, 2018
-- | ||
-- It's often the case that some adjustable computation fed with sum types only | ||
-- needs incremental adjustments when the variant stays the same but data within | ||
-- changes, and only need be done from scatch when the the variant changes. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'scratch' ?
alexfmpe
reviewed
Jul 28, 2018
-- | ||
-- The singleton ['sing'], eliminator, and 'Prism'' family together connect the | ||
-- sum type ['sum'] with its variants. The singleton must be total in that there | ||
-- must be a singleon singleton assigned to each variant. The 'Prism'' family |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'singleon' ?
hSloan
added
follow up
Follow up with requester to take some action
opinionated
Requires judgement from senior developer or developer community
labels
Jan 23, 2019
414owen
force-pushed
the
factorable-sum
branch
from
January 14, 2020 14:56
5d65a2e
to
9fe2950
Compare
414owen
force-pushed
the
factorable-sum
branch
from
January 16, 2020 15:36
9fe2950
to
a484431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
follow up
Follow up with requester to take some action
non-breaking change
opinionated
Requires judgement from senior developer or developer community
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They avoid the
sample
s offactorDyn
by embracing thewidgetHold
pattern.I am 100% cargo culting names here.