Build incremental #222
Open
Build incremental #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-batchelor
force-pushed
the
buildIncremental
branch
from
d39cce6
to
ce9a877
Compare
Add mapIncremental (Monadic, not unsafe) Add some basic tests for mapIncremental
oliver-batchelor
force-pushed
the
buildIncremental
branch
from
ce9a877
to
d4840d7
Compare
hSloan
added
the
opinionated
lpsmith
added
enhancement
non-breaking change
breaking change
and removed
non-breaking change
labels
|
The breakage here is because this adds a new method to the Reflex class. It also includes a default method for the implementation, but it does specify additional constraints, and I'm not sure without further study what might not be covered by this default method; however the breakage might be very minimal. It also uncomments and fixes the type of another default method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this kicking around, so I figured I might as well add a couple of tests and submit it for completeness. It seems useful for writing containers. One very simple thing it enables is a safe
mapIncrementalwhich is monadic, but avoids thesamplewhich would otherwise be required.