WIP: Refactor Requester modules #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e hood) for EventWriterT
…e-fix-nonempty-deferred # Conflicts: # src/Reflex/PerformEvent/Base.hs
…ix-nonempty-deferred
3noch
reviewed
Dec 11, 2019
src/Reflex/PerformEvent/Base.hs
Outdated
| (result0, requests0) <- lift $ runA a0 | ||
| newA <- requestingIdentity $ runA <$> a' | ||
| requests <- switchHoldPromptOnly requests0 $ fmapCheap snd newA | ||
| --TODO: promptly *prevent* events, then sign up the new ones; this is a serious breaking change to PerformEvent |
There was a problem hiding this comment.
Just want to call this out so we don't neglect it in review and testing.
There was a problem hiding this comment.
This same comment appears in a few places.
lpsmith
added
breaking change
bug fix
clean up
This was referenced Jan 15, 2020
JBetz
force-pushed
the
requester-simple-fix-nonempty-deferred
branch
from
442826d
to
aa51587
Compare
JBetz
force-pushed
the
requester-simple-fix-nonempty-deferred
branch
from
aa51587
to
bcf920c
Compare
…ix-nonempty-deferred
414owen
force-pushed
the
requester-simple-fix-nonempty-deferred
branch
from
6904992
to
d2d152d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and cleanup, also confirmed to fix at least one bug in Adjustable (#369).