Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflex.Network: improve haddocks #500

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Jun 10, 2024

  • Replace reference to deprecated function with its replacement
  • Normalise comment formatting
  • Suggest how to flatten the result of networkHold

* Replace reference to deprecated function with its replacement
* Normalise comment formatting
* Suggest how to flatten the result of `networkHold`
@alexfmpe
Copy link
Member

*promptly ? That doesn't sound like something we want to recommend outside of very specific situations. I can only remember using it once in 5+ years

@endgame
Copy link
Contributor Author

endgame commented Jun 11, 2024

I haven't used networkHold much at all, but the previous version of the docs referenced a ...Promptly function. I think otherwise you miss any event firings from the frame that swaps the network in, and that's usually something I want (to capture).

@ali-abrar
Copy link
Member

Agree we should rethink the use of promptly here, but that isn't new to this PR.

@ali-abrar ali-abrar merged commit ccc8208 into reflex-frp:develop Jun 12, 2024
17 checks passed
@endgame endgame deleted the patch-1 branch June 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants