Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about requesting semantics #508

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LightAndLight
Copy link

@LightAndLight LightAndLight commented Sep 13, 2024

This seems to be the case for Obelisk's HTTP requester. Should it be true in general? Is this the right place to document it?

Being explicit about this matters to me, because it's possible to implement a requester has the request and response events fire at the same time. If that were the case, then you wouldn't be able to, say, transition a DOM element to "loading" while a request was in flight.

@bglgwyng
Copy link

bglgwyng commented Sep 13, 2024

#505
Actually, my fix is to handle immediate responses. I'm not certain about the semantics, but it feels buggy when I play with my app. It's very likely that someone will write an immediate response for test purposes as I did.

@maralorn
Copy link
Contributor

maralorn commented Nov 1, 2024

I have recently had a similar issue. In my opinion users of the class shouldn’t make any assumptions about the timing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants