Additional engine #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encode gzip with upload/download
|
I think reg-viz/reg-cli#93 causes the above circleCI failure. |
|
reg-suit detected visual differences. Check this report, and review them. 🔴 🔵🔵🔵🔵🔵 What balls mean?The number of balls represents the number of images change detected.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers accepts this differences, the reg context status will be green automatically. |
bokuweb
approved these changes
Nov 21, 2017
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part work of reg-viz/reg-cli#90 .
I introduce
ximgdiffoption tocoreconfig, and set the invocation type valueclient.But this option is extremely experimental. So If you prefer turning it off by default, I change it so.
And I modify S3 plugin:
.jsand.wasmtooContentEncoding: gzipheader. Because it's too slow to download no-compressed WASM file from S3...