-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add
testing.T#Cleanup()
support (#12)
## Summary This pull request introduces a wrapper for `*rapid.T` called `rapidT` to address compatibility issues with the `TestingT` interface. The changes include adding a `Cleanup()` method to the `TestingT` interface and implementing the `rapidT` wrapper with a stub for the `Cleanup()` method. The wrapper is used in `runScenario` function to maintain compatibility and provide better integration between `rapid` and `testing` packages. *NOTE: step definition signatures using `*rapid.T` are unaffected (i.e. backwards compatible change)* ## Rationale We have some non-trivial, common test helpers that occasionally reach for `t.Cleanup(...)`. I acknowledge that the `After` is intended for suite cleanup but I think this is an equally valid case.
- Loading branch information
1 parent
2ec3df5
commit 8dd45c4
Showing
5 changed files
with
45 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters