fix: example tests #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me 👍 |
aaronc
approved these changes
Jan 8, 2024
0xste
pushed a commit
that referenced
this pull request
Feb 13, 2024
This moves all example code from _examples/ into examples/ as per #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems in the example tests:
_examplesfolder ;TestApi, the test'sResponseRecorderinstance kept in thesuitestruct wasn't being reset which was leading to it mixing up responses from different test cases, hence making tests fail (the failures weren't being caught by CI because of the underscore issue outlined above).This PR fixes above issues by renaming
_examplestoexamples(1) and by adding aBeforehook in the tests to reset the response recorder (2).