feat: add and update api examples and demo #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanchristo
commented
Jul 12, 2023
ryanchristo
commented
Jul 12, 2023
flagrede
approved these changes
Jul 12, 2023
| if (!result && !error) executeExample(); | ||
| }, [result, error]); | ||
|
|
||
| const executeExample = async (): Promise<void> => { |
There was a problem hiding this comment.
Usually, async function definition goes into useEffect or even better outside, in a separate file. This is just to prevent the function to be redeclared in each render. Since this is just a demo moving the function inside the useEffect should be enough.
There was a problem hiding this comment.
Thanks! Updated e02cfd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the examples and provides implementations of the examples in the demo app.