Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add credit class certifications and update project ratings to be a list #59

Merged
merged 8 commits into from
Jul 4, 2023

Conversation

blushi
Copy link
Member

@blushi blushi commented Jul 3, 2023

Description

ref: regen-network/rnd-dev-team#1710

Updating the actual projects/credit classes metadata on prod will be tackled as part of regen-network/rnd-dev-team#1737


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • reviewed documentation is accurate
  • manually tested (if applicable)

@@ -0,0 +1,81 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the generic project metadata fields to this project.jsonld file, similarly to what's been done for credit-class.jsonld

@@ -1,114 +1,59 @@
@prefix dash: <http://datashapes.org/dash#> .
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto added a generic project.ttl

@@ -48,5 +48,11 @@
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually debating whether we need those credit classes template jsonld files or not
because we'll only have one instance of a given credit class metadata so maybe we could get rid of those (ditto for C02-...-credit-class.jsonld below) cc/ @wgwz

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm, i'm ok with removing the templates for credit classes

@blushi blushi requested a review from a team July 3, 2023 08:55
@blushi blushi changed the title feat: add credit class certification and update project ratings to be a list feat: add credit class certifications and update project ratings to be a list Jul 3, 2023
Copy link
Contributor

@wgwz wgwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blushi blushi merged commit 2f6d54f into main Jul 4, 2023
1 check passed
@blushi blushi deleted the feat-1710-ratings-certifications branch July 4, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants