-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add credit class certifications and update project ratings to be a list #59
Conversation
@@ -0,0 +1,81 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the generic project metadata fields to this project.jsonld file, similarly to what's been done for credit-class.jsonld
@@ -1,114 +1,59 @@ | |||
@prefix dash: <http://datashapes.org/dash#> . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto added a generic project.ttl
@@ -48,5 +48,11 @@ | |||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually debating whether we need those credit classes template jsonld files or not
because we'll only have one instance of a given credit class metadata so maybe we could get rid of those (ditto for C02-...-credit-class.jsonld below) cc/ @wgwz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, i'm ok with removing the templates for credit classes
ops/C01/credit-class-metadata/C01-verified-carbon-standard-credit-class.jsonld
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
ref: regen-network/rnd-dev-team#1710
Updating the actual projects/credit classes metadata on prod will be tackled as part of regen-network/rnd-dev-team#1737
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...