Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for storing impact/co-benefits and sdgs related info in anchored metadata #64

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

blushi
Copy link
Member

@blushi blushi commented Aug 9, 2023

Description

Closes: #63

We are still missing the actual data for the existing classes (in particular which co-benefits are measured or not) so waiting on that but the rest can be reviewed already.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • reviewed documentation is accurate
  • manually tested (if applicable)

@blushi blushi requested a review from a team August 9, 2023 09:47
@blushi blushi changed the title feat: Add support for storing impact/co-benefits related info in anchored metadata feat: Add support for storing impact/co-benefits and sdgs related info in anchored metadata Aug 9, 2023
@blushi blushi marked this pull request as draft August 9, 2023 12:13
@blushi blushi marked this pull request as ready for review August 9, 2023 12:31
] ;
sh:property [
sh:path regen:primaryImpact ;
sh:nodeKind sh:IRI ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we use this? just would like to understand better.

Copy link
Member Author

@blushi blushi Aug 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we expect the regen:primaryImpact to have an @id (ie an IRI that we can use to identify it), see https://www.w3.org/TR/shacl/#NodeKindConstraintComponent.
If that wasn't the case, it would just be a blank node instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok. thanks for explaining

Copy link
Contributor

@wgwz wgwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! i'll be glad to approve once we get the actual data

@blushi
Copy link
Member Author

blushi commented Aug 30, 2023

@wgwz I've created a follow-up issue for updating metadata: #69
so I think we can merge this as soon as this is approved, could you have a final look? thanks

Copy link
Contributor

@wgwz wgwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
"regen:coBenefits": [
{
"@id": "",
Copy link
Member Author

@blushi blushi Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the id could be regen:Biodiversity for instance and is a reliable way of getting the image for this particular item from sanity based on the id and display it on the project page
it also grows our regen vocabulary, in which we could define further info (eg description) about a particular impact/co-benefit

@blushi blushi merged commit 910186d into main Aug 31, 2023
1 check passed
@blushi blushi deleted the feat-63-class-impact branch August 31, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for storing impact/co-benefits and sdgs related info in anchored metadata
2 participants