-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for storing impact/co-benefits and sdgs related info in anchored metadata #64
Conversation
] ; | ||
sh:property [ | ||
sh:path regen:primaryImpact ; | ||
sh:nodeKind sh:IRI ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we use this? just would like to understand better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we expect the regen:primaryImpact
to have an @id
(ie an IRI that we can use to identify it), see https://www.w3.org/TR/shacl/#NodeKindConstraintComponent.
If that wasn't the case, it would just be a blank node instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, ok. thanks for explaining
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! i'll be glad to approve once we get the actual data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
}, | ||
"regen:coBenefits": [ | ||
{ | ||
"@id": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the id could be regen:Biodiversity
for instance and is a reliable way of getting the image for this particular item from sanity based on the id and display it on the project page
it also grows our regen vocabulary, in which we could define further info (eg description) about a particular impact/co-benefit
…in class metadata
4124c86
to
12be3ce
Compare
Description
Closes: #63
We are still missing the actual data for the existing classes (in particular which co-benefits are measured or not) so waiting on that but the rest can be reviewed already.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...