Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: first project card spacing, title and icon #1991

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

blushi
Copy link
Member

@blushi blushi commented Jul 31, 2023

Description

Closes: regen-network/rnd-dev-team#1628


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Go to https://deploy-preview-1991--regen-registry.netlify.app/ecocredits/projects and login using an address that is a credit class issuer but doesn't have any project yet
  2. You should see the "create project" card with the fixes

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 0f405d4
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64c7baaaaae71a000815c2c3
😎 Deploy Preview https://deploy-preview-1991--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested a review from a team July 31, 2023 13:44
@blushi
Copy link
Member Author

blushi commented Jul 31, 2023

@erikalogie see testing instructions above

@erikalogie
Copy link
Collaborator

@blushi which address "is a credit class issuer but doesn't have any project yet"?

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACk. One thing I noticed though is the create project and create batch cards have different widths, one is full width and the other is not. I'm not sure if this was intentional, if it can be quickly addressed here, or if we should handle separately.

Screenshot from 2023-07-31 09-25-18

Screenshot from 2023-07-31 09-22-11

@erikalogie
Copy link
Collaborator

tACk. One thing I noticed though is the create project and create batch cards have different widths, one is full width and the other is not. I'm not sure if this was intentional, if it can be quickly addressed here, or if we should handle separately.

Screenshot from 2023-07-31 09-25-18

Screenshot from 2023-07-31 09-22-11

this was intentional

@blushi
Copy link
Member Author

blushi commented Aug 1, 2023

@blushi which address "is a credit class issuer but doesn't have any project yet"?

It seems like your address regen1ttl8xqmyt346hgp79yh949c4l8gw4wz9rmqcrg is an issuer without any project yet @erikalogie

@erikalogie
Copy link
Collaborator

ok thanks, this looks good!

@blushi blushi merged commit 08267fc into dev Aug 1, 2023
14 checks passed
@blushi blushi deleted the fix-1628-first-project-card branch August 1, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Create your first project" card has messed up spacing
3 participants