fix: useCallback to define retryCsrfRequest to avoid infinite loop #2259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2258
As part of #2252 which introduced this bug,
retryCsrfRequest
was added to the dependency array of thelogin
callback. BecauseretryCsrfRequest
wasn't declared withuseCallback
and always changing, this was causing theuseEffect
inuseAutoConnect
(which indirectly depends onlogin
that depends onretryCsrfRequest
) to trigger indefinitely, eventually causing the app to error.This issue was reproducible when logging in with an account that has a wallet address (which triggers
tryConnectWallet
inuseAutoConnect
) and then going to another page or reloading the app.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...