-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: QR code not displayed on first attempt to connect via Wallet Connect on desktop / chromium browsers #2279
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
<WalletProvider> | ||
<LedgerProvider> | ||
<ThemeProvider> | ||
<ThemeProvider> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we needed to move the ThemeProvider
up so the LoginModalMobile
provided as walletModal
to ChainProvider
renders with our MUI theme
@paul121 @erikalogie please see testing instructions above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better... although I did experience the same issue the very first time I loaded the page and clicked WC. Loading the page again, however, and it works. You can test this in an incognito window. Clearing local storage for this site will also "reset" this and cause the error on next load.
The modal doesn't seem to have everything it needs the first time it loads. But subsequent loads are fine. I think it makes sense how these changes fixed the subsequent loads. Any idea for the first load?
When I tested in Safari, the modal got stuck on the loading animation the first time I tried this. Then the second time I clicked, I saw a QR code right away. |
LGTM! |
96a9241
to
0cda117
Compare
0cda117
to
6bffaa4
Compare
Description
Closes: #2275
There was something weird happening with our existing implementation (custom). It was working fine in most browsers (Firefox, Safari), except chromium based browsers when the dev tools wasn't open for some reason (#2275 (comment)).
So instead I've set it up so that we define a
customModal
for the cosmos-kitChainProvider
, this modal only gets displayed when trying to connect with wallet connect, since we only use cosmos-kit for that so far. This also seems like a cleaner solution anyway, which involves less custom code (see code diff stats).Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...