Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save and next button behavior #2298

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

blushi
Copy link
Member

@blushi blushi commented Feb 27, 2024

Description

Closes: #2290


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Go to https://deploy-preview-2298--regen-marketplace.netlify.app
  2. Log in and go to https://deploy-preview-2298--regen-marketplace.netlify.app/profile/projects
  3. Create a new project
  4. Fill in the basic info form, adding some decimal value for the size and hit "save & exit"
  5. This should save and go back to /profile/projects page

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from a team February 27, 2024 13:09
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 5bcddc0
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/65e328284f43f1000811eff0
😎 Deploy Preview https://deploy-preview-2298--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Feb 27, 2024

@erikalogie see testing instructions

@erikalogie
Copy link
Collaborator

@blushi LGTM

@blushi blushi force-pushed the fix-2290-save-next-basic-info branch from caeb038 to 5bcddc0 Compare March 2, 2024 13:22
@blushi blushi merged commit c1d2fc9 into dev Mar 2, 2024
14 checks passed
@blushi blushi deleted the fix-2290-save-next-basic-info branch March 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix save and exit button in project creation forms
3 participants