Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roles form missing image upload and empty wallet address bug #2305

Merged
merged 6 commits into from
Mar 26, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Feb 29, 2024

Description

Closes: #2282
Also fixes a bug mentioned by @ticalubin when trying to add a new profile with no address, closes: #2316


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

From https://deploy-preview-2305--regen-marketplace.netlify.app:

  1. Go to https://deploy-preview-2305--regen-marketplace.netlify.app/profile/projects and create or edit a project
  2. From the Roles form, from the "Project Developer" or "Verifier" dropdown, add a new profile
  3. Upload a profile image but leave the wallet address field empty and save the profile
  4. Save the project
  5. Go to your project page and check out the added role

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@blushi blushi requested a review from a team February 29, 2024 15:28
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit e6d7aa2
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66027e7013c5680008b4a298
😎 Deploy Preview https://deploy-preview-2305--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi
Copy link
Member Author

blushi commented Feb 29, 2024

@erikalogie see testing instructions

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing this and it did not work for me. First I tried an SVG image and it accepted that but the image didn't show up at all. Second I tried a JPG and that showed up, but then I got an error:
image

Also, generally I'm finding the concept of being able to add roles in this way kind of confusing. But that's a separate conversation maybe to have in a design sync. For now, let's just get this fix working.

@blushi
Copy link
Member Author

blushi commented Mar 4, 2024

I tried testing this and it did not work for me. First I tried an SVG image and it accepted that but the image didn't show up at all. Second I tried a JPG and that showed up, but then I got an error: image

Also, generally I'm finding the concept of being able to add roles in this way kind of confusing. But that's a separate conversation maybe to have in a design sync. For now, let's just get this fix working.

I'm unable to reproduce those issues, both svg and png uploads work and show up on the project page for me.
Which browser are you using?
Also could you link the svg you were using?
When you get the "Something went wrong" error, could you look at the dev tools network tab and check the error message from the failing request?
Thanks.

@erikalogie
Copy link
Collaborator

This is working for me

@aaronc
Copy link
Member

aaronc commented Mar 6, 2024

I posted a screen capture in Slack.

@blushi blushi changed the title fix: roles form missing image upload fix: roles form missing image upload and wallet address bug Mar 7, 2024
@blushi blushi changed the title fix: roles form missing image upload and wallet address bug fix: roles form missing image upload and empty wallet address bug Mar 7, 2024
@blushi blushi requested a review from clevinson March 20, 2024 07:06
@clevinson
Copy link
Member

clevinson commented Mar 25, 2024

Just tested, and this looks good to me.

If we were actually going to keep this feature in production as is, then I would like us to also have a better error message than "Sorry, something went wrong!" if a user enters a wallet address that is already associated with another profile.

However, since we are planning to hide this feature until we have a better UX flow for the roles, I'm fine to merge this as is and then follow up with merging #2329

@blushi blushi force-pushed the fix-2282-roles-form branch from 4d575b3 to e6d7aa2 Compare March 26, 2024 07:51
@blushi blushi merged commit a89a743 into dev Mar 26, 2024
14 checks passed
@blushi blushi deleted the fix-2282-roles-form branch March 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants