-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: roles form missing image upload and empty wallet address bug #2305
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie see testing instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried testing this and it did not work for me. First I tried an SVG image and it accepted that but the image didn't show up at all. Second I tried a JPG and that showed up, but then I got an error:
Also, generally I'm finding the concept of being able to add roles in this way kind of confusing. But that's a separate conversation maybe to have in a design sync. For now, let's just get this fix working.
This is working for me |
I posted a screen capture in Slack. |
Just tested, and this looks good to me. If we were actually going to keep this feature in production as is, then I would like us to also have a better error message than "Sorry, something went wrong!" if a user enters a wallet address that is already associated with another profile. However, since we are planning to hide this feature until we have a better UX flow for the roles, I'm fine to merge this as is and then follow up with merging #2329 |
4d575b3
to
e6d7aa2
Compare
Description
Closes: #2282
Also fixes a bug mentioned by @ticalubin when trying to add a new profile with no address, closes: #2316
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
From https://deploy-preview-2305--regen-marketplace.netlify.app:
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...